Merged
Conversation
dmohns
reviewed
Mar 12, 2026
beesaferoot
force-pushed
the
normalize-phonenumbers-db
branch
from
f02a586 to
f826f33
Compare
dmohns
approved these changes
Mar 18, 2026
Comment on lines
22
to
27
| public function rules(): array { | ||
| return [ | ||
| 'city_id' => ['required'], | ||
| 'phone' => ['phone:INTERNATIONAL'], | ||
| ]; | ||
| } |
Member
There was a problem hiding this comment.
More a question, not a request for change: What is the difference between rules on the Request and rules on the Model itself?
Contributor
Author
There was a problem hiding this comment.
What is the difference between rules on the Request and rules on the Model itself?
The request rule enforces the correct structure on the client level, while the model rule enforces it on the DB level, which can bypass the request layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1361
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.